incorrect_length_validation: Consider inclusion validations as an alternative#220
Merged
gregnavis merged 1 commit intoAug 9, 2025
Merged
Conversation
gregnavis
requested changes
Apr 24, 2025
gregnavis
left a comment
gregnavis
left a comment
Owner
There was a problem hiding this comment.
Great fix! I left some comments.
fatkodima
force-pushed
the
consider-inclusion-validations
branch
from
e88a478 to
7867d40
Compare
Contributor
Author
|
Made updates. |
gregnavis
requested changes
Aug 5, 2025
gregnavis
left a comment
gregnavis
left a comment
Owner
There was a problem hiding this comment.
@fatkodima, I reviewed the PR again, and found two other edge cases to cover. We're almost at the finish line and I'd love to see this merged. Thank you for your work.
Owner
|
Also, could we add a test case with an enum? |
fatkodima
force-pushed
the
consider-inclusion-validations
branch
from
7867d40 to
4dd13fd
Compare
Contributor
Author
Needs changes to the checker and test cases. I think this is not really related to this PR and better done separately. |
fatkodima
force-pushed
the
consider-inclusion-validations
branch
from
4dd13fd to
4fbb40d
Compare
gregnavis
approved these changes
Aug 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #205.